From e429c4aa559926be86762c08a06ce2569731a170 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Lu=C3=ADs=20Henriques?= Date: Tue, 9 Nov 2021 17:55:55 +0000 Subject: [PATCH] common/renameat2: use mktemp(1) to create temporary directory MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Instead of using $TEST_DIR/$$, use the _correct_ way to create temporary directories. I've seen generic/626 failing with: QA output created by 626 mkdir: cannot create directory '/media/test/471': File exists Silence is golden which was likely due to another test that used the same directory name and didn't do the clean-up. Signed-off-by: Luís Henriques Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- common/renameat2 | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/common/renameat2 b/common/renameat2 index 4d25d7ce..9737dff5 100644 --- a/common/renameat2 +++ b/common/renameat2 @@ -105,14 +105,13 @@ _rename_tests() _require_renameat2() { local flags=$1 - local rename_dir=$TEST_DIR/$$ + local rename_dir=`mktemp -d -p $TEST_DIR` local cmd="" if test ! -x $here/src/renameat2; then _notrun "renameat2 binary not found" fi - mkdir $rename_dir touch $rename_dir/foo case $flags in "noreplace") -- 2.30.2