From ebfd5ba86ada74bb5d16e502ec8382184d639de2 Mon Sep 17 00:00:00 2001 From: Andreas Gruenbacher Date: Sat, 3 Feb 2018 19:57:35 +0100 Subject: [PATCH] check: Fix exit status Exit with status 1 if there were any failures: using the number of failed tests as the exit status makes no sense and can easily overwrap. In addition, clean up a few minor things. Signed-off-by: Andreas Gruenbacher Reviewed-by: Eryu Guan Signed-off-by: Eryu Guan --- check | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/check b/check index 58a2f5cc..546683c5 100755 --- a/check +++ b/check @@ -194,6 +194,7 @@ trim_test_list() done grep -v -f $tmp.grep <$tmp.list >$tmp.tmp mv $tmp.tmp $tmp.list + rm -f $tmp.grep } @@ -250,7 +251,7 @@ _prepare_test_list() # sort the list of tests into numeric order list=`sort -n $tmp.list | uniq` - rm -f $tmp.list $tmp.tmp $tmp.grep + rm -f $tmp.list if $randomize then @@ -803,7 +804,6 @@ for section in $HOST_OPTIONS_SECTIONS; do then bad="$bad $seqnum" n_bad=`expr $n_bad + 1` - quick=false tc_status="fail" fi if $do_report; then @@ -822,5 +822,5 @@ for section in $HOST_OPTIONS_SECTIONS; do done interrupt=false -status=`expr $sum_bad` +status=`expr $sum_bad != 0` exit -- 2.30.2