]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mds: Don't blocklist clients in any replay state 47111/head
authorKotresh HR <khiremat@redhat.com>
Fri, 24 Jun 2022 07:17:57 +0000 (12:47 +0530)
committerKotresh HR <khiremat@redhat.com>
Fri, 15 Jul 2022 02:45:25 +0000 (08:15 +0530)
commit0117f97e365e3e143a0831209efb23b1e229a9b1
treec1900091e118b32dad77a7e30ecfdbd3f8881b62
parente27cc18f0c47a7cec9f2094f64c1bdcaf8825f06
mds: Don't blocklist clients in any replay state

The mds in 'standby-replay' state should not blocklist clients.
Attempting to do so would hit an assert while journaling.

Before the commit 79f7576 the 'Server:apply_blocklist' used to
fetch the blocklist addresses from 'Objecter::consume_blocklist_events'
which returns blocklist addresses only if 'blocklist_events_enabled'
are enabled. This is not enabled for mds in 'standby-replay' state.
Hence this issue wasn't seen.

After the commit 79f7576 the 'Server::apply_blocklist' fetches the
blocklist addresses from the osdmap. This would return the blocklist
addresses irrespective of the mds state. The mds in 'replay' state
doesn't blocklist the clients but if the mds is in 'standby-replay'
state, it tries to journal the blocklist and asserts. This patch
fixes the same by not allowing the blocklist if the mds is in any
replay state.

Introduced-by: 79f7576401cc9d857f84396314d7476336c0e271
Fixes: https://tracker.ceph.com/issues/56012
Signed-off-by: Kotresh HR <khiremat@redhat.com>
(cherry picked from commit 733fb72acfeb79adbb26166ca13b1e5927cd6547)
src/mds/MDSRank.cc