]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS 55501/head
authorKefu Chai <tchaikov@gmail.com>
Fri, 15 Dec 2023 11:03:57 +0000 (19:03 +0800)
committerCasey Bodley <cbodley@redhat.com>
Thu, 8 Feb 2024 17:05:58 +0000 (12:05 -0500)
commit027a39869c4ce4c143073a269dbdaca6823ef6ae
tree6a9cbd53d2495f9a3ca23ae5ddefe1a33b2aeed7
parent8ead859fdc34864efce912762092ac9e463824e8
cmake/modules/BuildRocksDB.cmake: inherit parent's CMAKE_CXX_FLAGS

CMake allows us to customize `CMAKE_CXX_FLAGS` by setting CXXFLAGS
environmental variable. and Debian's debhelper also sets CXXFLAGS
when it builds cmake projects for customizing the building flags.

but we fail to populate this setting down when building external
projects. this is important when it comes to the projects which
is critical to the performance. RocksDB is one of them.

in this change, we pass the `CMAKE_CXX_FLAGS` down in
`BuildRocksDB.cmake` so that its `CMAKE_CXX_FLAGS` contains
the same set of `CMAKE_CXX_FLAGS` used by its parent project.

this should help with the performance in the bluestore, where
RocksDB is used.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
(cherry picked from commit beb1a624921d7589db63dea066935b3aa9ce2698)
cmake/modules/BuildRocksDB.cmake