]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mon: Monitor: do not reopen MonitorDBStore during conversion
authorJoao Eduardo Luis <joao.luis@inktank.com>
Tue, 16 Jul 2013 15:45:39 +0000 (16:45 +0100)
committerSage Weil <sage@inktank.com>
Tue, 16 Jul 2013 17:31:46 +0000 (10:31 -0700)
commit036e6739a4e873863bae3d7d00f310c015dfcdb3
treeb25119d5013e4a398440021293519fe4c622ae84
parent38691e7f957a819325c50da0503c086cd96172d1
mon: Monitor: do not reopen MonitorDBStore during conversion

We already open the store on ceph_mon.cc, before we start the conversion.
Given we are unable to reproduce this every time a conversion is triggered,
we are led to believe that this causes a race in leveldb that will lead
to 'store.db/LOCK' being locked upon the open this patch removes.

Regardless, reopening the db here is pointless as we already did it when
we reach Monitor::StoreConverter::convert().

Fixes: #5640
Backport: cuttlefish

Signed-off-by: Joao Eduardo Luis <joao.luis@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
src/mon/Monitor.cc