]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/cephadm: add test coverage for action chosen in _check_daemons
authorJohn Mulligan <jmulligan@redhat.com>
Wed, 11 Mar 2026 19:44:39 +0000 (15:44 -0400)
committerJohn Mulligan <jmulligan@redhat.com>
Thu, 26 Mar 2026 13:31:38 +0000 (09:31 -0400)
commit03f137e7c1b2b16c4ec61de8de6c4f02e50dbd56
tree495f4370487d0ef3cf5e6ec895e5a9c11f6d44be
parent390f97e07696c46bdbd49eeae20a94c0ee083c40
mgr/cephadm: add test coverage for action chosen in _check_daemons

Add a test that verifies that the special cases for the ingress daemon
when fronting nfs choice of action is handled.

Fix the error in the current code block so that the test passes. I have
discussed this with Shweta, the author of this code block, and we
agree it should have been `last_deps`.

NOTE: While this test tries to assert the correct action is chosen via a
mock, I have also examined that it takes the correct code path when by
viewing coverage results locally.

Co-authored-by: Shweta Bhosale <Shweta.Bhosale1@ibm.com>
Signed-off-by: John Mulligan <jmulligan@redhat.com>
src/pybind/mgr/cephadm/serve.py
src/pybind/mgr/cephadm/tests/services/test_nfs.py