]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
os/FileStore: reset journal state on umount
authorSage Weil <sage@inktank.com>
Tue, 8 Apr 2014 17:52:43 +0000 (10:52 -0700)
committerSage Weil <sage@inktank.com>
Wed, 9 Apr 2014 15:47:17 +0000 (08:47 -0700)
commit06f27fc6446d47b853208357ec4277c5dc10d9fe
treeaf26eae1aadbe339afdb9cc7ae82b31fc0a43d89
parentb29238729f87c73dfdcf16dddcf293577678dea2
os/FileStore: reset journal state on umount

We observed a sequence like:

 - replay journal
   - sets JournalingObjectStore applied_op_seq
 - umount
 - mount
   - initiate commit with prevous applied_op_seq
 - replay journal
   - commit finishes
   - on replay commit, we fail assert op > committed_seq

Although strictly speaking the assert failure is harmless here, in general
we should not let state leak through from a previous mount into this
mount or else assertions are in general more difficult to reason about.

Fixes: #8019
Signed-off-by: Sage Weil <sage@inktank.com>
(cherry picked from commit 4de49e8676748b6ab4716ff24fd0a465548594fc)
src/os/JournalingObjectStore.cc
src/os/JournalingObjectStore.h