]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
Revert "osd/PGLog.cc: Trim duplicates by number of entries"
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 9 Jun 2022 21:36:17 +0000 (21:36 +0000)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 9 Jun 2022 21:36:17 +0000 (21:36 +0000)
commit08e540df17bf4d5e9cc6bc08755f5bce2f194371
tree25165f0818ad68d4f960e1edc0c2a4c2bb47ebef
parent38cc164540a578e1c2c19f565961d2d2d5c48d02
Revert "osd/PGLog.cc: Trim duplicates by number of entries"

This reverts commit 7cc1b29f2b7b7feee127f1dbbef947799e56f38b.
which is the in-OSD part of the fix for accumulation of `dup`
entries in a PG Log. Brainstorming it has brought questions
on the OSD's behaviour during an upgrade if there are tons of
dups in the log. What must be double-checked before bringing
it back is ensuring we chunk the deletions properly to not
impose OOMs / stalls in, to exemplify, RocksDB.

The backport ticket is: https://tracker.ceph.com/issues/55990

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/osd/PGLog.cc
src/osd/PGLog.h
src/test/osd/TestPGLog.cc
src/tools/ceph_objectstore_tool.cc