]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
Revert "tools/ceph_objectstore_took: Add duplicate entry trimming"
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 9 Jun 2022 21:30:51 +0000 (21:30 +0000)
committerRadosław Zarzyński <rzarzyns@redhat.com>
Sat, 11 Jun 2022 23:01:43 +0000 (01:01 +0200)
commit0b5a13bf982f6fd11faeded913639e244ca01c50
treee707df2e80a141edd2537cb3cd93a2eac7562e5c
parentea7429d37fb947e3390d55eead90ad8f50dd67d6
Revert "tools/ceph_objectstore_took: Add duplicate entry trimming"

This reverts commit 1f3fede173cf8224f4c9f1d24b30d6fa8dfda216.

Although the chunking in off-line `dups` trimming (via COT) seems
fine, the `ceph-objectstore-tool` is a client of `trim()` of
`PGLog::IndexedLog` which means than a partial revert is not
possible without extensive changes. Moreover, trimming pg log
is not enough without modifying pg_info_t accordingly which
the reverted patch lacks.

The backport ticket is: https://tracker.ceph.com/issues/55989

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/osd/PGLog.cc
src/osd/PGLog.h
src/test/osd/TestPGLog.cc
src/tools/ceph_objectstore_tool.cc