]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mds/LogEvent.h: change print() signature to const 50/head
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Tue, 12 Feb 2013 21:17:38 +0000 (22:17 +0100)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Tue, 12 Feb 2013 21:17:38 +0000 (22:17 +0100)
commit0c65cd5f5e93f2d3db9ac55b74c03a32144d331f
tree0ca89145751320d76c132c0edee3287f9b1118eb
parente2b8e0f13cea1ec0a5688b07032f5a392cce1049
mds/LogEvent.h: change print() signature to const

Fix print() function of src/mds/LogEvent.h, declare as

virtual void print(ostream& out) const {...}

Adapt functions of derived classes. This should fix a problem
with print function of derived classes EImportStart and
EImportFinish, which had a const signature, hiding virtual
function of the base class LogEvent (which wasn't const).

Fix -Woverloaded-virtual warning from clang was:

mds/events/EImportStart.h:43:8: warning: 'EImportStart::print'
 hides overloaded virtual function [-Woverloaded-virtual]
  void print(ostream& out) const {
       ^
mds/events/../LogEvent.h:95:16: note: hidden overloaded virtual
 function 'LogEvent::print' declared here
  virtual void print(ostream& out) {
               ^
In file included from mds/journal.cc:31:
mds/events/EImportFinish.h:35:8: warning: 'EImportFinish::print'
 hides overloaded virtual function [-Woverloaded-virtual]
  void print(ostream& out) const {
       ^
mds/events/../LogEvent.h:95:16: note: hidden overloaded
 virtual function 'LogEvent::print' declared here
  virtual void print(ostream& out) {

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
13 files changed:
src/mds/LogEvent.h
src/mds/events/ECommitted.h
src/mds/events/EExport.h
src/mds/events/EFragment.h
src/mds/events/EOpen.h
src/mds/events/EResetJournal.h
src/mds/events/ESession.h
src/mds/events/ESessions.h
src/mds/events/ESlaveUpdate.h
src/mds/events/ESubtreeMap.h
src/mds/events/ETableClient.h
src/mds/events/ETableServer.h
src/mds/events/EUpdate.h