]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
build/ops: refrain from installing/using lsb_release in install-deps.sh
authorNathan Cutler <ncutler@suse.com>
Wed, 1 Aug 2018 10:52:45 +0000 (12:52 +0200)
committerNathan Cutler <ncutler@suse.com>
Fri, 4 Oct 2019 15:20:29 +0000 (17:20 +0200)
commit105950dc0536baa2c343409735b0593fb1c7a7bd
tree1062182b06899fd8b9d0f56a4f0e5c67fae0daeb
parentc605cd81e60416a56fb4a152dcdedaf0a0ee64cb
build/ops: refrain from installing/using lsb_release in install-deps.sh

Unfortunately the mapping between release number and codename (which is only
relevant for Debian and Ubuntu btw) is not available from /etc/os-release.
In that one respect, lsb_release was "better".

However, when I weigh the advantages of obtaining that mapping from an external
tool, with the (substantial) risk that the external dependency might cause
trouble on one or more supported distros (to say nothing of the non- or
semi-/pseudo-supported ones), against the work involved in maintaining a
hard-coded mapping (negligible), the needle on my scale immediately swings
toward eliminating the dependency.

Also, I see this commit as part of the longer-term effort to completely expunge
lsb_release from our codebase. See git log --grep lsb_release.

For another example of an external distro-detection tool (albeit one that was
included in Python 2) gone awry, see http://tracker.ceph.com/issues/18163.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 38508b41dc7f33a0b35e3633be3da1d2dae844dc)

Conflicts:
install-deps.sh
install-deps.sh