]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mgr/cephadm: re-factoring the dependencies calculation code 60800/head
authorRedouane Kachach <rkachach@ibm.com>
Tue, 14 Jan 2025 09:34:27 +0000 (10:34 +0100)
committerRedouane Kachach <rkachach@ibm.com>
Tue, 14 Jan 2025 09:34:27 +0000 (10:34 +0100)
commit1280f0114dcd9f23c2b5149826b5b9d30555bc15
treeef6d7bfad141b78ff329e822405296293e9f70e2
parenta0f2a3b82fbcfe1f2593eeee35d93cfe0effa2f0
mgr/cephadm: re-factoring the dependencies calculation code

currently, the dependency logic is duplicated between the different Service
classes and the module.py::_calc_daemon_deps function, which can lead
to issues such as BUGSs, difficulty in maintenance, and other problems
associated with duplicated code. In this change, we are consolidating
all the dependency logic into the Service subclasses to eliminate this
duplication. This way, we also force anybody creating a new Service to
think about its potential dependencies.

Fixes: https://tracker.ceph.com/issues/69021
Signed-off-by: Redouane Kachach <rkachach@ibm.com>
src/pybind/mgr/cephadm/inventory.py
src/pybind/mgr/cephadm/module.py
src/pybind/mgr/cephadm/serve.py
src/pybind/mgr/cephadm/services/cephadmservice.py
src/pybind/mgr/cephadm/services/ingress.py
src/pybind/mgr/cephadm/services/iscsi.py
src/pybind/mgr/cephadm/services/jaeger.py
src/pybind/mgr/cephadm/services/mgmt_gateway.py
src/pybind/mgr/cephadm/services/monitoring.py
src/pybind/mgr/cephadm/services/node_proxy.py
src/pybind/mgr/cephadm/tests/test_services.py