]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
dmclock/.../dmclock_server: do not clean clients with requests 62364/head
authorSamuel Just <sjust@redhat.com>
Thu, 13 Feb 2025 04:16:47 +0000 (04:16 +0000)
committerSamuel Just <sjust@redhat.com>
Tue, 18 Mar 2025 17:43:58 +0000 (17:43 +0000)
commit16b8eb315090d9714730669a74eeb726f1a0a04f
tree0e67fa8f5639547604ac2c4a3d64d740daa64cfd
parentffa76372dc880fd2795584eb34c8b70688e63e14
dmclock/.../dmclock_server: do not clean clients with requests

PriorityQueueBase::do_clean() shouldn't remove ClientRec instances which
still have queued requests.  Otherwise, very low priority clients might
end up having requests actually lost, which shouldn't be possible.

In the OSD, this resulted in PGRecovery items being lost if queued with
background_best_effort while expanding a cluster.  Such items can
legitimately sit in the queue for a long period of time as they
represent background data migration which is allowed to be starved by an
aggressive client workload.  Dropping the items broke an assumption in
the OSD that all items enqueued would eventually be dequeued resulting
in resources being leaked.

Fixes: https://tracker.ceph.com/issues/61594
Signed-off-by: Samuel Just <sjust@redhat.com>
(cherry picked from commit 35cf0f6c1355ff420c431340ac36d9a3c029d6c2)
src/dmclock/src/dmclock_server.h