]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
osd/PG: skip rollforward when !transaction_applied during append_log()
authorNeha Ojha <nojha@redhat.com>
Mon, 4 Mar 2019 04:29:05 +0000 (20:29 -0800)
committerNeha Ojha <nojha@redhat.com>
Fri, 15 Mar 2019 16:48:10 +0000 (09:48 -0700)
commit17419ee39342257f5a6f41c792e8e45a8e243720
treeb9c7c2b42060f14821a8abbc849231050708c83c
parentbe00ec35135997929c4e2460f82bfe396ac5031c
osd/PG: skip rollforward when !transaction_applied during append_log()

Earlier, we did pg_log.roll_forward(&handler), when
!transaction_applied, which advanced the crt and trimmed the entries
in rollforward(). Due to this, during _merge_object_divergent_entries(),
when we tried to rollback entries, those objects were not found in the
backend, and thus we hit this bug http://tracker.ceph.com/issues/36739.

With this change, we are advancing the crt value, without deleting the
objects, so that _merge_object_divergent_entries() does not fail
because of deleted objects.

Fixes: http://tracker.ceph.com/issues/36739
Signed-off-by: Neha Ojha <nojha@redhat.com>
src/osd/PG.cc
src/osd/PGLog.h