]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
msgr: drop unnecessary (un)locking on queuing connection events
authorSage Weil <sage@inktank.com>
Mon, 9 Jul 2012 17:05:12 +0000 (10:05 -0700)
committerSage Weil <sage@inktank.com>
Tue, 10 Jul 2012 20:30:33 +0000 (13:30 -0700)
commit1a4a1330712b3912d4b3ccfa7709531f0f1efbf4
treec045621690413b25798446a6be4e646143b860c4
parente84565d9e8a57c5cf25e8452aee7fa7d789905ff
msgr: drop unnecessary (un)locking on queuing connection events

This used to be necessary because the pipe_lock was used when queueing
the pipe in the dispatch queue.  Now that is handled by IncomingQueue's
own lock, so these can be removed.

By no longer dropping the lock, we eliminate a whole category of potential
hard-to-debug races.  (Not that any were observed, but now we dno't need to
worry about them.)

Signed-off-by: Sage Weil <sage@inktank.com>
src/msg/Pipe.cc