]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
ceph-volume: fix raw activate by osd-id/osd-uuid
authorGuillaume Abrioux <gabrioux@ibm.com>
Thu, 29 Jun 2023 08:19:37 +0000 (10:19 +0200)
committerGuillaume Abrioux <gabrioux@redhat.com>
Wed, 15 May 2024 09:12:56 +0000 (09:12 +0000)
commit1ec2e79409cace15a2b308c25f567ffc383b46f0
tree8f1adf0b27c6d96f655e7b6012d98d9dfb97ddb2
parentda4a9fcb1bed6f59fca1a1982241d6b5f047a789
ceph-volume: fix raw activate by osd-id/osd-uuid

When activating a raw osd with `--osd-id` and `--osd-uuid` instead of
passing the device, it ends up with a call to List.generate() passing
`[None]` (which doesn't really make sense).
When no devices are passed tp List.generate(), it needs to enter the
first condition in order to build a list of all devices. Otherwise,
that function starts iterating on an empty list which result in a
failure (see corresponding tracker).

Fixes: https://tracker.ceph.com/issues/61855
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit b25e8e4ecc8f4187cf1f185e0e0f5a72aafe6a10)
src/ceph-volume/ceph_volume/devices/raw/activate.py