]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
librbd: relax requirements on finisher canceled callback
authorMykola Golub <mgolub@suse.com>
Wed, 28 Oct 2020 13:13:02 +0000 (13:13 +0000)
committerMykola Golub <mgolub@suse.com>
Wed, 28 Oct 2020 13:43:15 +0000 (13:43 +0000)
commit20b2ef931aaecb455b6eb292cb5c00b08f70d20e
treea00570bf8898aaa56310a5575b78f791e4276f00
parentf4cd2a17848876687cd364d2726f371d0efa9ae8
librbd: relax requirements on finisher canceled callback

The finisher timer is started with safe_callbacks = false, and
cancel_event may fail.

When canceling a task it is safe to just ignore the cancel_event
result and proceed, because the returned false value means the
callback is in TaskFinisher::complete already but before
acquiring the lock, so when it eventually acquires the lock it
will just find out the task is already deleted and return.

Signed-off-by: Mykola Golub <mgolub@suse.com>
src/librbd/TaskFinisher.h