]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
Revert "osd/PGLog.cc: Trim duplicates by number of entries"
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 9 Jun 2022 18:22:45 +0000 (18:22 +0000)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 9 Jun 2022 20:16:49 +0000 (20:16 +0000)
commit25bc8c1c4a9c5acdadc3df893d233fef8eac4018
tree07adccac02ba0baecbaf6d8c6029e65aaca41158
parent5d47b8e21e77a57e51781f00021f77c7967ebbe2
Revert "osd/PGLog.cc: Trim duplicates by number of entries"

This reverts commit 3ff0df6a28a1d9e197bdba40be7126fed8a14ae9
which is the in-OSD part of the fix for accumulation of `dup`
entries in a PG Log. Brainstorming it has brought questions
on the OSD's behaviour during an upgrade if there are tons of
dups in the log. What must be double-checked before bringing
it back is ensuring we chunk the deletions properly to not
impose OOMs / stalls in, to exemplify, RocksDB.

The backport ticket is: https://tracker.ceph.com/issues/55981

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/osd/PGLog.cc
src/osd/PGLog.h
src/test/osd/TestPGLog.cc
src/tools/ceph_objectstore_tool.cc