]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
pybind/mgr/*: fix config_notify handling of default values 34117/head
authorNathan Cutler <ncutler@suse.com>
Mon, 23 Mar 2020 14:41:16 +0000 (15:41 +0100)
committerNathan Cutler <ncutler@suse.com>
Tue, 24 Mar 2020 10:17:43 +0000 (11:17 +0100)
commit30585f44de6147c824ed2df1a477ad17f7b51fff
tree51ddf8ae2c12ef1a835a351a1bd9aeb49cc4471b
parent3f5a801d972694750c8fce7cc8b5136a37c82b43
pybind/mgr/*: fix config_notify handling of default values

After 5ace82e65c72847fb875fc01c419937a26a59d70 was merged, I found
three more instances of the code being patched.

The commit message of 5ace82e65c72847fb875fc01c419937a26a59d70 was/is:

"The default values are handled by mgr_module.py's _get_module_option();
the or here means that we break any non-true (0, false, none) value and
override it with the default."

Fixes: 5ace82e65c72847fb875fc01c419937a26a59d70
Fixes: https://tracker.ceph.com/issues/43746
Signed-off-by: Nathan Cutler <ncutler@suse.com>
src/pybind/mgr/diskprediction_cloud/module.py
src/pybind/mgr/diskprediction_local/module.py
src/pybind/mgr/osd_support/module.py