]> git.apps.os.sepia.ceph.com Git - xfstests-dev.git/commit
fstests: do not call _scratch_mkfs_sized in a pipe
authorEryu Guan <eguan@redhat.com>
Sun, 5 Nov 2017 06:14:11 +0000 (14:14 +0800)
committerEryu Guan <eguan@redhat.com>
Fri, 10 Nov 2017 04:33:38 +0000 (12:33 +0800)
commit32a8ebcbe6cf2c7ced5312724e6b69db85deb116
treec40bd2adf4ce95cc33d535d2dd2e407795424604
parent8fd019ba7a44507af94cde38df2e49709ba4b396
fstests: do not call _scratch_mkfs_sized in a pipe

_scratch_mkfs_sized will create a filesystem of the given size, and
call _notrun and exit if current $FSTYP doesn't support sized mkfs.
But when it's called in a pipe, the exit in _notrun only exits from
the subshell created by the pipe not the test itself, and test
continues to run unnecessarily, though the test is still reported as
[notrun] due to existence of $seqres.notrun file.

Fix it by not calling _scratch_mkfs_sized in a pipe, but dumping the
output to a tmp file, which will be fed to _filter_mkfs later.

Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Eryu Guan <eguan@redhat.com>
tests/generic/204
tests/xfs/015