]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
osd/PrimaryLogPG: fix potential pg-log overtrimming 23317/head
authorxie xingguo <xie.xingguo@zte.com.cn>
Mon, 30 Jul 2018 10:56:56 +0000 (18:56 +0800)
committerxie xingguo <xie.xingguo@zte.com.cn>
Thu, 20 Sep 2018 09:17:49 +0000 (17:17 +0800)
commit3654d56985c67d15506fa37b56ef5b0c04e01a65
tree501cccce1c27f5fbd48786a481071105b6d1f6f4
parentf557a78540e56a3197ca0e3173cc726afc18ac28
osd/PrimaryLogPG: fix potential pg-log overtrimming

In https://github.com/ceph/ceph/pull/21580 I set a trap to catch some wired
and random segmentfaults and in a recent QA run I was able to observe it was
successfully triggered by one of the test case, see:

```
http://qa-proxy.ceph.com/teuthology/xxg-2018-07-30_05:25:06-rados-wip-hb-peers-distro-basic-smithi/2837916/teuthology.log
```

The root cause is that there might be holes on log versions, thus the
approx_size() method should (almost) always overestimate the actual number of log entries.
As a result, we might be at the risk of overtrimming log entries.

https://github.com/ceph/ceph/pull/18338 reveals a probably easier way
to fix the above problem but unfortunately it also can cause big performance regression
and hence comes this pr..

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
src/osd/PrimaryLogPG.cc