]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rgw: cmake: remove useless civetweb include path side effect.
authorMarcus Watts <mwatts@redhat.com>
Fri, 4 Nov 2016 03:33:44 +0000 (23:33 -0400)
committerMarcus Watts <mwatts@redhat.com>
Fri, 13 Jan 2017 02:54:25 +0000 (21:54 -0500)
commit386640865dee30d38f17e55fc87535e419bc3cb5
tree05b95bcd31b50d96646dba4110e1f76f878ee541
parent15c081c6433e9ee4b6dd7c145e8e6aaddf334e69
rgw: cmake: remove useless civetweb include path side effect.

For 'target_include_directories" for the cmake object library
'civetweb_common_objs', change from PUBLIC to PRIVATE.  This doesn't
break anything, so it wasn't doing anything useful.  If it has it
any effect, it would be to cause everything that linked against this
"library" to also use the indictated include path.  Which would be great
except everything in ceph wants to include "civetweb/civetweb.h" and
not "civetweb.h".  We already make separate arrangements elsewhere for
that to work.  Additionally, static object libraries in cmake aren't
really libraries, so I'm not entirely sure this even does anything.
So: making this public is not useful, and could be harmful.  Making it
private makes this only take effect for building civetweb.c itself,
exactly the effect we we require, and no more.

Signed-off-by: Marcus Watts <mwatts@redhat.com>
(cherry picked from commit 8308a13b0257c9460fd2a721c20b0c37cb9e7c57)
src/CMakeLists.txt