]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
misc: mark constructors as explicit 21637/head
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Wed, 25 Apr 2018 07:30:56 +0000 (09:30 +0200)
committerDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Wed, 2 May 2018 15:01:58 +0000 (17:01 +0200)
commit39ffec281af577c766c619d568f7a7051d108b00
tree79c527cc3871b9b113f1aabffb3cef9647ebb7be
parent7810dde42ce082c318658320a4862b4c5c6d3f15
misc: mark constructors as explicit

Set 218 constructors as explicit to avoid implicit usage.

Fix for cppcheck warning:
 Class has a constructor with 1 argument that is
 not explicit. Such constructors should in general be explicit for
 type safety reasons. Using the explicit keyword in the constructor
 means some mistakes when using the class can be avoided.

 For more information check:
  https://www.codeproject.com/Articles/28663/Explicit-Constructor-in-C

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
138 files changed:
src/client/Client.h
src/common/Cond.h
src/common/ceph_json.cc
src/common/config.h
src/common/escape.cc
src/common/scrub_types.h
src/crush/CrushLocation.h
src/kv/MemDB.h
src/kv/RocksDBStore.cc
src/librbd/ImageState.cc
src/librbd/Journal.cc
src/librbd/cache/ImageWriteback.h
src/librbd/cache/PassthroughImageCache.h
src/librbd/io/ReadResult.cc
src/mds/CInode.h
src/mds/DamageTable.h
src/mds/OpenFileTable.h
src/mgr/DaemonServer.cc
src/mgr/DaemonState.h
src/mgr/Gil.h
src/mgr/MgrClient.h
src/mgr/MgrSession.h
src/mgr/PyModule.h
src/mgr/PyModuleRegistry.h
src/mgr/PyModuleRunner.h
src/mon/FSCommands.cc
src/msg/async/AsyncMessenger.cc
src/msg/async/dpdk/EventDPDK.h
src/msg/async/dpdk/Packet.h
src/msg/async/dpdk/UserspaceEvent.h
src/msg/async/dpdk/ethernet.h
src/msg/async/dpdk/net.h
src/msg/async/rdma/Infiniband.h
src/msg/async/rdma/RDMAStack.h
src/msg/xio/XioMessenger.h
src/osd/ExtentCache.h
src/osd/OSD.cc
src/osd/OSDCap.h
src/osd/OpQueueItem.h
src/osd/PG.cc
src/osd/PGLog.h
src/osd/PrimaryLogPG.cc
src/osd/PrimaryLogPG.h
src/osd/Watch.h
src/osd/osd_types.h
src/osdc/Journaler.cc
src/osdc/Objecter.h
src/rgw/rgw_acl_swift.h
src/rgw/rgw_asio_frontend.cc
src/rgw/rgw_auth.h
src/rgw/rgw_auth_filters.h
src/rgw/rgw_auth_keystone.cc
src/rgw/rgw_auth_s3.h
src/rgw/rgw_basic_types.h
src/rgw/rgw_civetweb.h
src/rgw/rgw_client_io.h
src/rgw/rgw_client_io_filters.h
src/rgw/rgw_coroutine.h
src/rgw/rgw_cr_rest.h
src/rgw/rgw_crypt.cc
src/rgw/rgw_crypt_sanitize.h
src/rgw/rgw_data_sync.cc
src/rgw/rgw_es_query.cc
src/rgw/rgw_es_query.h
src/rgw/rgw_file.cc
src/rgw/rgw_file.h
src/rgw/rgw_frontend.h
src/rgw/rgw_http_client.cc
src/rgw/rgw_http_client.h
src/rgw/rgw_http_client_curl.cc
src/rgw/rgw_iam_policy.h
src/rgw/rgw_keystone.h
src/rgw/rgw_lc.h
src/rgw/rgw_lc_s3.h
src/rgw/rgw_lib.h
src/rgw/rgw_metadata.h
src/rgw/rgw_op.cc
src/rgw/rgw_op.h
src/rgw/rgw_period_puller.h
src/rgw/rgw_period_pusher.h
src/rgw/rgw_process.h
src/rgw/rgw_rados.h
src/rgw/rgw_realm_reloader.cc
src/rgw/rgw_reshard.h
src/rgw/rgw_rest_client.cc
src/rgw/rgw_rest_config.h
src/rgw/rgw_rest_conn.h
src/rgw/rgw_rest_s3.h
src/rgw/rgw_rest_swift.cc
src/rgw/rgw_rest_swift.h
src/rgw/rgw_sync.cc
src/rgw/rgw_sync.h
src/rgw/rgw_sync_log_trim.cc
src/rgw/rgw_sync_module_aws.cc
src/rgw/rgw_sync_module_es_rest.cc
src/rgw/rgw_sync_module_log.cc
src/rgw/rgw_tar.h
src/test/cls_rbd/test_cls_rbd.cc
src/test/common/test_lru.cc
src/test/common/test_mclock_priority_queue.cc
src/test/common/test_static_ptr.cc
src/test/encoding/test_ceph_time.h
src/test/fio/fio_ceph_objectstore.cc
src/test/librbd/deep_copy/test_mock_ImageCopyRequest.cc
src/test/librbd/deep_copy/test_mock_ObjectCopyRequest.cc
src/test/librbd/deep_copy/test_mock_SetHeadRequest.cc
src/test/librbd/deep_copy/test_mock_SnapshotCopyRequest.cc
src/test/librbd/deep_copy/test_mock_SnapshotCreateRequest.cc
src/test/librbd/exclusive_lock/test_mock_PostAcquireRequest.cc
src/test/librbd/exclusive_lock/test_mock_PreAcquireRequest.cc
src/test/librbd/journal/test_mock_OpenRequest.cc
src/test/librbd/journal/test_mock_PromoteRequest.cc
src/test/librbd/journal/test_mock_Replay.cc
src/test/librbd/mirror/test_mock_DisableRequest.cc
src/test/librbd/test_librbd.cc
src/test/librbd/test_mirroring.cc
src/test/librbd/test_mock_DeepCopyRequest.cc
src/test/librbd/test_mock_ManagedLock.cc
src/test/librgw_file_aw.cc
src/test/librgw_file_gp.cc
src/test/mon/PGMap.cc
src/test/msgr/test_async_networkstack.cc
src/test/objectstore/BitAllocator_test.cc
src/test/objectstore/store_test_fixture.h
src/test/osd/types.cc
src/test/rbd_mirror/image_replayer/test_mock_CreateImageRequest.cc
src/test/rbd_mirror/image_replayer/test_mock_EventPreprocessor.cc
src/test/rbd_mirror/image_sync/test_mock_SyncPointCreateRequest.cc
src/test/rbd_mirror/image_sync/test_mock_SyncPointPruneRequest.cc
src/test/rbd_mirror/pool_watcher/test_mock_RefreshImagesRequest.cc
src/test/rbd_mirror/test_PoolWatcher.cc
src/test/rbd_mirror/test_mock_ImageSync.cc
src/test/rgw/test_rgw_common.h
src/test/rgw/test_rgw_iam_policy.cc
src/test/rgw/test_rgw_period_history.cc
src/test/test_any.cc
src/test/test_denc.cc
src/test/test_mempool.cc