]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mon/MonClient: remove stray _finish_hunting() calls
authorSage Weil <sage@inktank.com>
Fri, 2 May 2014 21:48:35 +0000 (14:48 -0700)
committerSage Weil <sage@inktank.com>
Tue, 20 May 2014 17:35:45 +0000 (10:35 -0700)
commit3b8ab41e1ec86f2ab5c6b4bee3fb4030077e2c21
tree045bdaec610ac744660b78171302df99295877ab
parenta915350491092abcd2584d0bbb5f5d8610ed89fc
mon/MonClient: remove stray _finish_hunting() calls

Callig _finish_hunting() clears out the bool hunting flag, which means we
don't retry by connection to another mon periodically.  Instead, we send
keepalives every 10s.  But, since we aren't yet in state HAVE_SESSION, we
don't check that the keepalives are getting responses.  This means that an
ill-timed connection reset (say, after we get a MonMap, but before we
finish authenticating) can drop the monc into a black hole that does not
retry.

Instead, we should *only* call _finish_hunting() when we complete the
authentication handshake.

Fixes: #8278
Backport: firefly, dumpling
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Joao Eduardo Luis <joao.luis@inktank.com>
(cherry picked from commit 77a6f0aefebebf057f02bfb95c088a30ed93c53f)
src/mon/MonClient.cc