]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
cls/journal: skip disconnected clients when finding min_commit_position 44690/head
authorMykola Golub <mgolub@suse.com>
Fri, 14 Jan 2022 18:21:29 +0000 (18:21 +0000)
committerArthur Outhenin-Chalandre <arthur.outhenin-chalandre@cern.ch>
Thu, 20 Jan 2022 14:27:24 +0000 (15:27 +0100)
commit40f72fa1407eab1416ac4ada7022ad3cf49bf5ea
treefd68f582fec869168291db88e7cd17985ada44e0
parent4b71540702cd7904413b6b4d680e89a75a85a31b
cls/journal: skip disconnected clients when finding min_commit_position

When a new journal client is registered, all already registered
clients are checked, and a client with min position is selected
as a position for the new client. Thus we may expect that
starting from the registered position all journal entries will be
available (not trimmed) for the new client.

But when looking for a min commit position, the client_register
function did not take into account that a registered client might
be in disconnected state, and in that case the journal entries
might be trimmed for this client.

Fixes: https://tracker.ceph.com/issues/53888
Signed-off-by: Mykola Golub <mgolub@suse.com>
(cherry picked from commit 078d72e5e6cfa41f809045ff03971ac8acf0d31e)
src/cls/journal/cls_journal.cc