]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mon: revert part of PaxosService::is_readable() change
authorSage Weil <sage@inktank.com>
Wed, 24 Apr 2013 00:16:31 +0000 (17:16 -0700)
committerSage Weil <sage@inktank.com>
Wed, 24 Apr 2013 00:16:31 +0000 (17:16 -0700)
commit48631c114acda864c03d71d0895ce9def9aadcd9
treebacc1048fe36fa9f29904ec8df023d5e1c1599af
parent0093d704e6bbf78cca915c6a534022e219fa0130
mon: revert part of PaxosService::is_readable() change

In 98e23980f4ab7ba289303f72da06721c84767293 is_readable() was changed to
call is_active(), but that has a check for is_bootstrapping(), so there is
a semantic change.

As a result, we may fail PaxosService::is_readable() (due to bootstrapping)
and then try to call Paxos::wait_for_readable().  That will assert that
Paxos::is_readable() is false, but it will be true and we will crash.

Revert that part of the change, since the semantic change was not
intentional.

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Greg Farnum <greg@inktank.com>
src/mon/PaxosService.h