]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
librbd/migration: close source image in OpenSourceImageRequest
authorIlya Dryomov <idryomov@gmail.com>
Fri, 26 Jul 2024 10:13:08 +0000 (12:13 +0200)
committerIlya Dryomov <idryomov@gmail.com>
Sat, 10 Aug 2024 21:12:22 +0000 (23:12 +0200)
commit5423bcccc96dbd20f5539a77a4e0186bf2e8f6e1
tree80c7821fd58eef6b7b91f7fe1e45b0b0e8282a7f
parente8976d308ecb8b722c9d9431e75fc032adf4e873
librbd/migration: close source image in OpenSourceImageRequest

Currently, on errors in FormatInterface::open(), RawFormat disposes
of src_image_ctx, but QCOWFormat doesn't, which is a leak.  Rather than
having each format do it internally, do it in OpenSourceImageRequest.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 63159d6b431470f5edc4b110cebf46865c550689)
src/librbd/migration/OpenSourceImageRequest.cc
src/librbd/migration/RawFormat.cc
src/test/librbd/migration/test_mock_RawFormat.cc