]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
osd/bluestore: Actually wait until completion in write_sync 28573/head
authorVitaliy Filippov <vitalif@yourcmc.ru>
Wed, 6 Mar 2019 23:01:18 +0000 (02:01 +0300)
committerNathan Cutler <ncutler@suse.com>
Sat, 15 Jun 2019 09:32:15 +0000 (11:32 +0200)
commit55ab7e002e4c3287b4c3bf49340465673018bb17
tree50f3ee28e1903d48438e7eb8c4b01c1b193c1687
parent100196fab43ed3a57cd3ae10eef931334ad209a0
osd/bluestore: Actually wait until completion in write_sync

This function is only used by RocksDB WAL writing so it must sync data.

This fixes #18338 and thus allows to actually set `bluefs_preextend_wal_files`
to true, gaining +100% single-thread write iops in disk-bound (HDD or bad SSD) setups.
To my knowledge it doesn't hurt performance in other cases.
Test it yourself on any HDD with `fio -ioengine=rbd -direct=1 -bs=4k -iodepth=1`.

Issue #18338 is easily reproduced without this patch by issuing a `kill -9` to the OSD
while doing `fio -ioengine=rbd -direct=1 -bs=4M -iodepth=16`.

Fixes: https://tracker.ceph.com/issues/18338 https://tracker.ceph.com/issues/38559
Signed-off-by: Vitaliy Filippov <vitalif@yourcmc.ru>
(cherry picked from commit c703cf9a7632cbd9f17e148ef203509549a28571)
src/os/bluestore/KernelDevice.cc