]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
cmake: do not pass PRE_BUILD to add_custom_command(OUTPUT) 62565/head
authorKefu Chai <tchaikov@gmail.com>
Sun, 30 Mar 2025 02:10:28 +0000 (10:10 +0800)
committerKefu Chai <tchaikov@gmail.com>
Sun, 30 Mar 2025 02:19:54 +0000 (10:19 +0800)
commit588a74c95dcc3f63c9c224349be783c03fca788b
tree092cf99b65c2d362598042fcd06d18184b724954
parent21f67af89261fb999419c51738b51be81fbf3516
cmake: do not pass PRE_BUILD to add_custom_command(OUTPUT)

Removes the invalid PRE_BUILD argument from add_custom_command(OUTPUT)
calls that was triggering CMake warnings. The PRE_BUILD option is only
valid for target-based custom commands and specifically with Visual
Studio generators.

Additionally sets the CMP0175 policy to NEW to ensure CMake fails on
invalid arguments to add_custom_command(), helping catch similar issues
earlier in the development process.

This change:

- Removes unnecessary PRE_BUILD argument from OUTPUT-based custom commands
- Sets CMP0175 policy to enforce validation of add_custom_command() arguments
- Resolves CMake warning in src/common/options/CMakeLists.txt

Reference:
https://cmake.org/cmake/help/latest/command/add_custom_command.html#build-events

The CMake warning looks like:

```
CMake Warning (dev) at src/common/options/CMakeLists.txt:34 (add_custom_command):
  The following keywords are not supported when using
  add_custom_command(OUTPUT): PRE_BUILD.

  Policy CMP0175 is not set: add_custom_command() rejects invalid arguments.
  Run "cmake --help-policy CMP0175" for policy details.  Use the cmake_policy
  command to set the policy and suppress this warning.
Call Stack (most recent call first):
  src/common/options/CMakeLists.txt:85 (add_options)
This warning is for project developers.  Use -Wno-dev to suppress it.
```

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
CMakeLists.txt
src/common/options/CMakeLists.txt