]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mon/OSDMonitor: Ensure kvmon() is writeable before handling "osd new" cmd 46689/head
authorSridhar Seshasayee <sseshasa@redhat.com>
Fri, 27 May 2022 08:59:07 +0000 (14:29 +0530)
committerSridhar Seshasayee <sseshasa@redhat.com>
Wed, 15 Jun 2022 09:07:41 +0000 (14:37 +0530)
commit59d6653a585807555867b3b3eaf5f5240bd2b087
tree8ac8f93720993f540327ecd42fe240cc65155764
parent3a850220b7e147a086eeba4262cc2f39d89fe83c
mon/OSDMonitor: Ensure kvmon() is writeable before handling "osd new" cmd

Before proceeding to handle "osd new" mon command as part of
OSDMonitor::prepare_command_impl(), a check is made to verify if the
authmon is writeable. Later on, prepare_command_osd_new() invokes
KVMonitor::do_osd_new() to create pending dmcrypt keys and calls
propose_pending(). The propose could fail (with an assertion failure)
if there was a prior mon command that resulted in the kvmon invoking
propose_pending().

In order to avoid such a situation, introduce a check to verify that
kvmon is also writeable in OSDMonitor::prepare_command_impl(). If it
is not writeable, the op is pushed into the wait_for_active context
queue to be retried later.

Fixes: https://tracker.ceph.com/issues/55773
Signed-off-by: Sridhar Seshasayee <sseshasa@redhat.com>
(cherry picked from commit 9a0d42c9fbcf64711a791edcf9cafdba57d901d7)
src/mon/OSDMonitor.cc