]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
neorados/test: use [[maybe_unused]] instead of GTEST_ATTRIBUTE_UNUSED_
authorKefu Chai <tchaikov@gmail.com>
Sun, 30 Mar 2025 03:14:01 +0000 (11:14 +0800)
committerKefu Chai <tchaikov@gmail.com>
Sun, 30 Mar 2025 03:31:40 +0000 (11:31 +0800)
commit5cfe9ce97c83588bec4c6724f71b8a58bb37c678
tree3034977c58233aa134a1cd2b1cc6893f1706883f
parent9a49523b3dc554a547c5f19a2b0d20980bc692f2
neorados/test: use [[maybe_unused]] instead of GTEST_ATTRIBUTE_UNUSED_

This change:

- Aligns with GoogleTest's own evolution, which now uses
  `[[maybe_unused]]` internally (via
  `GTEST_INTERNAL_ATTRIBUTE_MAYBE_UNUSED`) as of
  https://github.com/google/googletest/commit/5a37b517
- Leverages C++20 features already available in Ceph
- Removes dependency on GoogleTest internal macros
- Enables updating the GoogleTest submodule to silence CMake warnings

Using the standard C++ attribute provides better compatibility and
future-proofing than relying on GoogleTest's internal implementation
details.

This change also allows us to bump up googletest submodule to silence a
CMake warning.

Signed-off-by: Kefu Chai <tchaikov@gmail.com>
src/test/neorados/common_tests.h