]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rpm: drop use of $FIRST_ARG in ceph-immutable-object-cache 42509/head
authorNathan Cutler <ncutler@suse.com>
Thu, 22 Jul 2021 20:52:39 +0000 (22:52 +0200)
committerNathan Cutler <ncutler@suse.com>
Tue, 27 Jul 2021 16:09:17 +0000 (18:09 +0200)
commit6148de6b52d24d3a821d4f456e59fde8c4509292
treeb93b3cfdafa2f7e92d5c599d11261750c217d4a2
parent6c3babe75efe98a54802997a7bb1328fc9d01d70
rpm: drop use of $FIRST_ARG in ceph-immutable-object-cache

The use of $FIRST_ARG was probably required because the SUSE-specific
%service_* rpm macros were playing tricks on the shell positional parameters.
This is bad practice and error-prone, so let's assume that no macros should do
that anymore and hence it's safe to assume that positional parameters remain
unchanged after any rpm macro call.

Thanks to Franck Bui for providing the original patch
926433f5d45e557c42f050b43798ba29dc495e02 that this patch is modeled after.

NOTE: the use of FIRST_ARG had already been eliminated by
926433f5d45e557c42f050b43798ba29dc495e02 but was re-introduced later by
9466d7098573dafcfede5e9c852374fbbd99f9e7

Fixes: 9466d7098573dafcfede5e9c852374fbbd99f9e7
Fixes: https://tracker.ceph.com/issues/51797
Signed-off-by: Nathan Cutler <ncutler@suse.com>
(cherry picked from commit 1cb84a1160ed4108cae30100682b1e3ee7c7721d)
ceph.spec.in