]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
projects / ceph.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 32b7295) | patch
rbd-mirror: straighten ImageReplayer::stop() a bit
authorIlya Dryomov <idryomov@gmail.com>
Sat, 19 Feb 2022 15:43:04 +0000 (16:43 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Wed, 23 Feb 2022 13:26:20 +0000 (14:26 +0100)
commit6284274b791faf74c8e0ce608565401305b6404c
tree58d0630209155b6db696d7fbe0f164aacd20a59dtree | snapshot
parent32b72959eeb10ac04a4ad6e70338278c577a0ff7commit | diff
rbd-mirror: straighten ImageReplayer::stop() a bit

- don't default on_finish parameter
- m_restart_requested is set in ImageReplayer::restart() which is the
  only restart=true call site, so setting m_restart_requested here is
  redundant
- is_stopped_() can't be true in is_running_() branch
- on_finish->complete(0) in the end is unreachable

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit 219c500977bbfbcfe4ccd24beb294edbe0562d35)
src/test/rbd_mirror/test_mock_ImageReplayer.cc diff | blob | history
src/tools/rbd_mirror/ImageReplayer.cc diff | blob | history
src/tools/rbd_mirror/ImageReplayer.h diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.