]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rgw: fix segfault in UserAsyncRefreshHandler::init_fetch 49083/head
authorCory Snyder <csnyder@iland.com>
Wed, 2 Feb 2022 09:46:59 +0000 (04:46 -0500)
committerCory Snyder <csnyder@iland.com>
Mon, 28 Nov 2022 07:55:44 +0000 (02:55 -0500)
commit63232b0eba6134adea1b8e67e553cf2894fc1d63
tree4bd1d87b1e2e93988f5e926c1e27c42574748f3a
parent1eca59d3fca02719370f4fa8337a64dad73c3051
rgw: fix segfault in UserAsyncRefreshHandler::init_fetch

Fixes a segfault that was occuring in error handling code of UserAsyncRefreshHandler::init_fetch.
When ruser->read_stats_async returned an error code, the instance of UserAsyncRefreshHandler had
already been deallocated in RGWSI_User_RADOS::read_stats_async and a segmentation fault occurs
when attempting to print a member variable in error logs. This commit removes the extra ref count
drop since the ref is properly dropped upstream in RGWQuotaCache::async_refresh error handling
logic.

Fixes: https://tracker.ceph.com/issues/54112
Signed-off-by: Cory Snyder <csnyder@iland.com>
(cherry picked from commit 71ef3af870e5789e71480682f11a883ff3a673e7)
src/rgw/services/svc_user_rados.cc