]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
test/subprocess: add missing space in SubshellKilled subcommand 69949/head
authorSun Yuechi <sunyuechi@iscas.ac.cn>
Mon, 6 Jul 2026 08:06:09 +0000 (01:06 -0700)
committerSun Yuechi <sunyuechi@iscas.ac.cn>
Mon, 6 Jul 2026 08:06:09 +0000 (01:06 -0700)
commit6aa58ca1eca9d15febe4f1cbbd4d1004e35015ea
treea1b5d00ea1592f02484ec162a79ad91601a5d242
parent5bc195949ab4a82c5de4ac1416f6270df90f9a31
test/subprocess: add missing space in SubshellKilled subcommand

9abf2388f24 rewrote "sh -c cat" as SHELL "-c cat", which concatenates
to "/bin/sh-c cat", so the subshell tries to execute a non-existent
"/bin/sh-c". The test still passed because the SIGTERM sent by kill()
usually wins the race against the shell startup; under CI load the
shell occasionally prints

  /bin/sh: line 1: /bin/sh-c: No such file or directory

into the stderr pipe first, ASSERT_TRUE(buf.empty()) fails, and the
skipped join() turns this into a SIGABRT in ~SubProcess().

Signed-off-by: Sun Yuechi <sunyuechi@iscas.ac.cn>
src/test/test_subprocess.cc