]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
crimson/os/alienstore/CMakeLists: Cleanup alien::cflags interface
authorMatan Breizman <mbreizma@redhat.com>
Mon, 9 Jun 2025 07:58:29 +0000 (07:58 +0000)
committerMatan Breizman <mbreizma@redhat.com>
Thu, 3 Jul 2025 07:57:23 +0000 (07:57 +0000)
commit6c1f4c646cf41c418eb9442d4f5a2772f71e310e
tree3eb565871312f7bf3c22e5640b1f17538e86ba4a
parentb6da1c2c16cb5e2ca4fb8a39032a04d258f0f719
crimson/os/alienstore/CMakeLists: Cleanup alien::cflags interface

alienstore FTBFS [1] due to virtual-dtor warning when compiling seastar [2].
Instead of using alien::cflags which define INTERFACE_COMPILE_OPTIONS of
-Wno-non-virtual-dtor - Let's directly add this compile option to
tagets using seastar.

Crimson non-alien targets solve that with crimson::cflags which
defines the relevant compile flag. However, we don't reuse it here since
it also carries WITH_CRIMSON.

As both crimson::cflags and crimson-alienstore which are using seastar
have to set no-non-virtual-dtor - The compile option moved to the common
cmake file instead of setting it in both targets.

[1]
```
crimson/os/alienstore/alien_log.cc:21:28:   required from here
seastar/include/seastar/core/future.hh:666:7:
warning: ‘class seastar::continuation_base<void>’ has virtual functions
and accessible non-virtual destructor [-Wnon-virtual-dtor]
```

[2] See 36963dd7ccd50eff2f8b91d97ffb66295a7a6292

Signed-off-by: Matan Breizman <mbreizma@redhat.com>
src/CMakeLists.txt
src/crimson/CMakeLists.txt
src/crimson/os/alienstore/CMakeLists.txt