]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
msg/simple/Pipe: avoid returning 0 on poll timeout 12375/head
authorSage Weil <sage@redhat.com>
Thu, 8 Dec 2016 00:25:55 +0000 (18:25 -0600)
committerSage Weil <sage@redhat.com>
Thu, 8 Dec 2016 00:25:55 +0000 (18:25 -0600)
commit6c3d015c6854a12cda40673848813d968ff6afae
treea0cabf2543878f0774108ecd534964371aa99624
parentcd56396a8ac97d0a831750e557cd8b6c783a24ca
msg/simple/Pipe: avoid returning 0 on poll timeout

If poll times out it will return 0 (no data to read on socket).  In
165e5abdbf6311974d4001e43982b83d06f9e0cc we changed tcp_read_wait from
returning -1 to returning -errno, which means we return 0 instead of -1
in this case.

This makes tcp_read() get into an infinite loop by repeatedly trying to
read from the socket and getting EAGAIN.

Fix by explicitly checking for a 0 return from poll(2) and returning
EAGAIN in that case.

Fixes: http://tracker.ceph.com/issues/18184
Signed-off-by: Sage Weil <sage@redhat.com>
src/msg/simple/Pipe.cc