]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/volumes: Deprecate protect/unprotect CLI calls for subvolume snapshots 36126/head
authorShyamsundar Ranganathan <srangana@redhat.com>
Tue, 23 Jun 2020 20:53:46 +0000 (16:53 -0400)
committerShyamsundar Ranganathan <srangana@redhat.com>
Sat, 18 Jul 2020 11:40:28 +0000 (07:40 -0400)
commit6cd4e2fd04eba2cd015c9caf9f7a6de1c5defaaa
tree7439b5bd84c634ede0b5a60bd9727333d0d3bae3
parent405556b2629d8274dea2e14ee017c70a7dfb24a1
mgr/volumes: Deprecate protect/unprotect CLI calls for subvolume snapshots

Subvolume snapshots required to be protected, prior to cloning the same.

Also, protected snapshots were not allowed to be unprotected or removed,
if there were in-flight clones, whose source was the snapshot being
removed.

The protection of snapshots explicitly is not required, as these can be
prevented from being removed based only on the in-flight clones checks.

This commit hence deprecates the additional protect/unprotect requirements
prior to cloning a snapshot.

In addition to deprecating the above, support to query a subvolume for
supported features, via the info command, is added. The feature list
is set to "clone" and "auto-protect", where the latter is useful to
decide if protect/unprotect commands are required or not.

Fixes: https://tracker.ceph.com/issues/45371
Signed-off-by: Shyamsundar Ranganathan <srangana@redhat.com>
(cherry picked from commit c52a7383d391864b7dce3ba09197a077a998dff7)

Conflicts:
        doc/cephfs/fs-volumes.rst
- added line space for correcting multi-line command rendering
doc/cephfs/fs-volumes.rst
qa/tasks/cephfs/test_volumes.py
src/pybind/mgr/volumes/fs/operations/template.py
src/pybind/mgr/volumes/fs/operations/versions/subvolume_base.py
src/pybind/mgr/volumes/fs/operations/versions/subvolume_v1.py
src/pybind/mgr/volumes/fs/volume.py
src/pybind/mgr/volumes/module.py