]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
rgw: RGWRESTOp no longer tracks separate error code 37052/head
authorCasey Bodley <cbodley@redhat.com>
Tue, 8 Sep 2020 17:53:36 +0000 (13:53 -0400)
committerCasey Bodley <cbodley@redhat.com>
Thu, 10 Sep 2020 16:34:56 +0000 (12:34 -0400)
commit701f019a763bf6f3f12d1cc1aa90583441f79d0c
tree1c16562a26bcc7ce5e1aa0d532fda108ef1a9b43
parent4ae71a068f2a7f27cfdfc7fc06ed42d5051caccc
rgw: RGWRESTOp no longer tracks separate error code

RGWOp_Bucket_Remove::execute() was storing failures from
bucket->remove_bucket() in op_ret, but left http_ret=0 so we responded
to the client with '200 OK'

to avoid bugs like this, remove the extra http_ret variable and only use
the op_ret from RGWOp

Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/rgw/rgw_rest.cc
src/rgw/rgw_rest.h
src/rgw/rgw_rest_bucket.cc
src/rgw/rgw_rest_config.cc
src/rgw/rgw_rest_log.cc
src/rgw/rgw_rest_metadata.cc
src/rgw/rgw_rest_realm.cc
src/rgw/rgw_rest_usage.cc
src/rgw/rgw_rest_user.cc