]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
common: drop the unused prune() of {safe,mutable}_item_history.
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Thu, 16 Jan 2020 12:21:25 +0000 (13:21 +0100)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Fri, 17 Jan 2020 16:33:01 +0000 (17:33 +0100)
commit717db0e8d959e61a8d8678c1a80151fa0fc6de8c
treed2c658a6efe70953b7adca2ed26d0b29b4920296
parentaf0e482a3fe8ec66b4681b9604ca7bcb28faf934
common: drop the unused prune() of {safe,mutable}_item_history.

The presence of these never-used methods obscure bug investigation.
For instance, `safe_item_history` is used to record all messenger's
addresses. As we never lock reading from it in `_conn_prefix()`, we
expect they live as long their corresponding messenger instances.
When such an item becomes corrupted, presence of `prune()` imposes
verification the method is never called – this effort could have
been avoided if we hadn't have the dangerous method.

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/common/item_history.h