]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
ceph-volume: quick fix in zap.py 51196/head
authorGuillaume Abrioux <gabrioux@ibm.com>
Wed, 29 Mar 2023 14:58:11 +0000 (16:58 +0200)
committerGuillaume Abrioux <gabrioux@ibm.com>
Mon, 24 Apr 2023 11:19:34 +0000 (13:19 +0200)
commit735ed0b7d9cca5289365cefc8c3afd4bda2d1f16
tree9e76316e0aa1ad19708cd45eb940deb18514f5b1
parent420400f4a425b4efa346ad397dc36d6449a27072
ceph-volume: quick fix in zap.py

`api.get_single_pv(filters={'lv_uuid': lv.lv_uuid})` needs to be called
only if `--destroy` is passed in order to remove vg and pv when there's
nothing left.

With old deployments, it is possible that a lv_uuid matches more than 1
PV.
Given that `get_single_pv()` is only needed when `--destroy` is passed,
let's move this call where it is actually needed.

This makes `ceph-volume lvm zap` fail even though

Fixes: https://tracker.ceph.com/issues/59210
Signed-off-by: Guillaume Abrioux <gabrioux@ibm.com>
(cherry picked from commit a666f700f16937565484dffc90713f6c04d76313)
src/ceph-volume/ceph_volume/devices/lvm/zap.py