]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
Makefle: force char to be signed
authorSage Weil <sage@inktank.com>
Thu, 16 May 2013 06:02:10 +0000 (23:02 -0700)
committerSage Weil <sage@inktank.com>
Thu, 16 May 2013 06:02:10 +0000 (23:02 -0700)
commit769a16d6674122f3b537f03e17514ad974bf2a2f
tree1f9a84afe1f6fa3f55facfecc886a3f0c437b07c
parent1d6ed811adb068d7540411311279c51c53fd5443
Makefle: force char to be signed

On an armv7l build, we see errors like

 warning: rgw/rgw_common.cc:626:16: comparison is always false due to limited range of data type [-Wtype-limits]

from code

      char c1 = hex_to_num(*src++);
...
      if (c1 < 0)

Force char to be signed (regardless of any weird architecture's default)
to avoid risk of this leading to misbehavior.

Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Dan Mick <dan.mick@inktank.com>
src/Makefile.am