]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
librados: fix locking for AioCompletionImpl refcounting
authorJosh Durgin <josh.durgin@inktank.com>
Tue, 13 Aug 2013 02:17:09 +0000 (19:17 -0700)
committerSage Weil <sage@inktank.com>
Wed, 14 Aug 2013 16:50:12 +0000 (09:50 -0700)
commit7a52e2ff5025754f3040eff3fc52d4893cafc389
treef6dbd1d3d52bba43f86ea65813bd1a01685b6dda
parent8ff6901141c9dc89ca93d749989f556aaedc65b4
librados: fix locking for AioCompletionImpl refcounting

Add an already-locked helper so that C_Aio{Safe,Complete} can
increment the reference count when their caller holds the
lock. C_AioCompleteAndSafe's caller is not holding the lock, so call
regular get() to ensure no racing updates can occur.

This eliminates all direct manipulations of AioCompletionImpl->ref,
and makes the necessary locking clear.

The only place C_AioCompleteAndSafe is used is in handling
aio_flush_async(). This could cause a missing completion.

Refs: #5919
Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
Reviewed-by: Sage Weil <sage@inktank.com>
Tested-by: Oliver Francke <Oliver.Francke@filoo.de>
src/librados/AioCompletionImpl.h