]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
crimson: PG::submit_error_log returns eversion_t rather than optional
authorSamuel Just <sjust@redhat.com>
Fri, 20 Sep 2024 02:39:08 +0000 (19:39 -0700)
committerSamuel Just <sjust@redhat.com>
Tue, 15 Oct 2024 03:37:26 +0000 (20:37 -0700)
commit7a826eb86c423e895345557632091a934f7c7d7e
tree6cdc71740ea4acd4d09ee7047e6d229b2a931897
parent5e28a3bd3b58353ff29cf1cd1b9627575158c290
crimson: PG::submit_error_log returns eversion_t rather than optional

It seems like the motivation here was to allow do_osd_ops_execute to
communicate that it didn't submit an error log by making
maybe_submit_error_log a std::optional<eversion_t>.  However,
submit_error_log itself always returns a version.  Fix submit_error_log
and compensate in do_osd_ops_execute.

Signed-off-by: Samuel Just <sjust@redhat.com>
src/crimson/osd/pg.cc
src/crimson/osd/pg.h