]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
test/pybind/rbd: don't ignore from_snapshot in check_diff() 54951/head
authorIlya Dryomov <idryomov@gmail.com>
Sun, 10 Dec 2023 16:01:24 +0000 (17:01 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Wed, 17 Jan 2024 17:19:55 +0000 (18:19 +0100)
commit7bbf92be4cc4b644bccf795f09935b05e602a52c
tree02ac03d6aa0358387ba064f20df7e4aa91452f70
parentb289d646f8a54633cf0ec788647bbc04e04e8222
test/pybind/rbd: don't ignore from_snapshot in check_diff()

Despite the test in test_diff_iterate() being correct, it started
failing:

    >       check_diff(self.image, 0, IMG_SIZE, 'snap1', [(0, 512, False)])
    ...
    a = [], b = [(0, 512, False)]
    ...
    >       assert a == b
    E       AssertionError

This is because check_diff() drops 'snap1' argument on the floor and
passes None to image.diff_iterate() instead.  This goes back to 2013,
see commit e88fe3cbbc8f ("rbd.py: add some missing functions").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
(cherry picked from commit f8ced6d1fe667864bee224104c23b62a2c1c0bfc)
src/test/pybind/test_rbd.py