]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rbd: assorted cli arg parsing fixes
authorIlya Dryomov <idryomov@gmail.com>
Tue, 21 Jul 2015 15:11:20 +0000 (18:11 +0300)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 27 Jul 2015 09:22:04 +0000 (12:22 +0300)
commit7d65bd9bd1b00582b635be62771d960bde701028
tree44b9ce09675bbc05d81f18ba5ddab015b8a2fabc
parentb60e144cebc9f5f1916adbb7e43f67af4988699f
rbd: assorted cli arg parsing fixes

- import-diff needs image-spec, yet OPT_IMPORT_DIFF was in the list of
  commands that don't need imgname

- check for lock id after imgname, so that if imgname isn't specified
  we fail with imgname rather than lock id error message

- error out if locker isn't specified

- move feature-name validity check after imgname checks so that if
  imgname is malformed we fail with imgname rather than feature error
  message

- error out if image-meta key or value isn't specified

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
src/rbd.cc
src/test/cli/rbd/invalid-snap-usage.t
src/test/cli/rbd/not-enough-args.t