]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
mon/MDSMonitor: batch last_metadata update with pending 52229/head
authorPatrick Donnelly <pdonnell@redhat.com>
Tue, 4 Apr 2023 18:03:49 +0000 (14:03 -0400)
committerPatrick Donnelly <pdonnell@redhat.com>
Wed, 28 Jun 2023 15:28:51 +0000 (11:28 -0400)
commit7df0b7cfea45ecb5b6ef159731aa3a422b0ed49a
treecaabe08682c8c369a6ec5986f575aedb552f97a7
parentded79cade7c970598db7a77c957a3ab8da3db2bc
mon/MDSMonitor: batch last_metadata update with pending

I believe the problem here is that the last_metadata change is lost in a
ECANCELED/EAGAIN transaction but the pending map change goes through in
the next one. I've been unable to find an exact way to reproduce this.
The problem seems to occur when upgrades are performed which would
indicate shuffling in the monitors where quorum would be lost repeatedly.

This seems to be the most likely explanation so let's go ahead and make
this change even without the reproducer. In any case, it has the added
benefit of batching the pending map update (to up:standby) with the
last_metadata update.

Fixes: https://tracker.ceph.com/issues/24403
Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 6f69fe9739a23974a46a4e13e4c29b431d95acc4)
src/mon/MDSMonitor.cc