]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
rgw: S3 Put Bucket Policy should return 204 on success 35059/head
authorMatthew Oliver <moliver@suse.com>
Thu, 14 May 2020 01:31:56 +0000 (11:31 +1000)
committerMatthew Oliver <moliver@suse.com>
Thu, 14 May 2020 01:37:53 +0000 (11:37 +1000)
commit7fddff78c98ef9a3c73581b892c7dfa04b64cdb3
tree110a77db433bbbee5d6ff90cec71f9fab34c5d14
parent929a9e64bb4bd9233a9321c468cb684abc59ed3f
rgw: S3 Put Bucket Policy should return 204 on success

Currently RGW returns a 200 on a successful PUT on a bucket policy but
the S3 api extects a 204, which makes sense as it's a success without
any contect returned:

   https://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketPUTpolicy.html

The sample response in the example above is a 204.

This patch checks the op_ret in `RGWPutBucketPolicy::send_response()`
and on a success we turn it to a 204 (or STATUS_NO_CONTENT).

Fixes: https://tracker.ceph.com/issues/45467
Signed-off-by: Matthew Oliver <moliver@suse.com>
src/rgw/rgw_op.cc