]> git.apps.os.sepia.ceph.com Git - ceph.git/commit
ceph-volume: fix a bug in _check_generic_reject_reasons
authorKim Minjong <make.dirty.code@gmail.com>
Fri, 3 Feb 2023 02:47:47 +0000 (11:47 +0900)
committerKonstantin Shalygin <k0ste@k0ste.ru>
Fri, 8 Dec 2023 16:28:17 +0000 (23:28 +0700)
commit801f074a894d286c3e04ea3da625dd2ae82d22e7
treebb940aa1fc65bcaac57d8ff1445ab8f204115d5e
parentca73cc8896faaec50a1a3ff255f8ddc289af9bf8
ceph-volume: fix a bug in _check_generic_reject_reasons

The types of removable and ro are wrong. Here, both filters are not
working at all. Changed this from integer to string and corrected the test
data.

Delete redundant logic in get_block_devs_sysfs. Given the name of the
function, I think it is correct to judge from _check_generic_reject_reasons,
and in fact it was before v17.2.4.

Fixes: https://tracker.ceph.com/issues/58591
Signed-off-by: Kim Minjong <make.dirty.code@gmail.com>
(cherry picked from commit a78e660728c6c0442cdbfa65db776b5856aee933)
src/ceph-volume/ceph_volume/tests/util/test_device.py
src/ceph-volume/ceph_volume/util/device.py
src/ceph-volume/ceph_volume/util/disk.py