]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commit
mgr/dashboard: [Dashboard] Incorrect action button label "Edit User" instead of ... 68845/head
authorpujaoshahu <pshahu@redhat.com>
Mon, 11 May 2026 13:07:53 +0000 (18:37 +0530)
committerpujashahu <pshahu@redhat.com>
Wed, 22 Jul 2026 09:04:06 +0000 (14:34 +0530)
commit81feb0d1c90fd922b7464638a204be71df8fade2
tree88a601ed9abf8aab3e8240c38d92ae7eeafe988f
parent091c0d01da81236bfbf88feffb68f2e571c73d5b
mgr/dashboard: [Dashboard] Incorrect action button label "Edit User" instead of "Save" in Edit User page

Fixes: https://tracker.ceph.com/issues/76507
Signed-off-by: pujaoshahu <pshahu@redhat.com>
Summary: Updated submit button labels in edit forms to display "Save" instead of "Edit User", "Edit Pool", or "Edit Host" for better UX consistency, while keeping form titles unchanged.

Modified Files
role-form.component.ts: Added submitAction property to control submit button label by mode; edit mode uses Save changes, create mode uses Create Role.

role-form.component.html: Submit button now binds to submitAction instead of action/resource text.

role-form.component.spec.ts: Added tests for submitAction behavior in create and edit modes.

user-form.component.ts: Uses submitAction property; edit mode label updated to Save changes.

user-form.component.html: Submit button uses submitAction binding.

user-form.component.spec.ts: Added/updated tests covering submitAction behavior.

pool-form.component.ts: Uses submitAction property; edit mode label updated to Save changes.

pool-form.component.html: Submit button uses submitAction binding.

pool-form.component.spec.ts: Updated submit label test expectation for edit mode.

hosts.component.ts: Edit host modal submit button text changed to Save changes.

hosts.component.spec.ts: Updated test to match Save changes button text.

app.constants.ts: In the current workspace snapshot, there is no SAVE constant added under ActionLabelsI18n.

Signed-off-by: pujaoshahu <pshahu@redhat.com>
Signed-off-by: pujashahu <pshahu@redhat.com>
16 files changed:
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-form/rbd-form.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-form/rbd-form.component.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/hosts/hosts.component.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/services/service-form/service-form.component.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.html
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/pool/pool-form/pool-form.component.ts
src/pybind/mgr/dashboard/frontend/src/app/core/auth/role-form/role-form.component.html
src/pybind/mgr/dashboard/frontend/src/app/core/auth/role-form/role-form.component.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/core/auth/role-form/role-form.component.ts
src/pybind/mgr/dashboard/frontend/src/app/core/auth/user-form/user-form.component.html
src/pybind/mgr/dashboard/frontend/src/app/core/auth/user-form/user-form.component.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/core/auth/user-form/user-form.component.ts
src/pybind/mgr/dashboard/frontend/src/app/shared/constants/app.constants.ts
src/pybind/mgr/dashboard/frontend/src/app/shared/services/host-action.service.ts